Changes between Version 60 and Version 61 of DeveloperGuidelines/CodeConventions

Timestamp:

01/26/16 12:10:22 (9 years ago)

Author:

Dominic König

Comment:

--

DeveloperGuidelines/CodeConventions

@@ -103 +103 @@
 
 {{{
-    s = s3_unicode(s)
-}}}
-
-4) We assume that any (external) function we call may attempt to convert input by calling str() - so we generally deliver all strings as utf-8 encoded str to prevent !UnicodeDecodeErrors. This can be done by:
+    s_slice = s3_unicode(s)[:4]
+}}}
+
+4) To ensure correct behavior of lower() and upper() conversion, we convert into unicode first, using s3_unicode:
+
+{{{
+   s_lowercase = s3_unicode(s).lower().encode("utf-8")
+}}}
+
+5) We assume that any (external) function we call may attempt to convert input by calling str() - so we generally deliver all strings as utf-8 encoded str to prevent !UnicodeDecodeErrors. This can be done by:
 
 {{{
@@ -118 +124 @@
 }}}
 
-5) System-strings (like table or field names, attribute names, etc.) should never contain non-ASCII characters, so that they safely pass through str().
-
-6) In reading XML, we follow the encoding specified in the XML declaration rather than making assumptions about the encoding. For all other sources, we 
+6) System-strings (like table or field names, attribute names, etc.) should never contain non-ASCII characters, so that they safely pass through str().
+
+7) In reading XML, we follow the encoding specified in the XML declaration rather than making assumptions about the encoding. For all other sources, we 
 assume utf-8 (see 2). In exports, we always write utf-8.
 
-7) All code is utf-8 encoded, so that all string constants are automatically utf-8 encoded str. We do not use u"..." for string constants.
-
-8) Note that, in Python 2, str.lower() and str.upper() may not work correctly for some unicode characters (e.g. "Ẽ".lower() gives "Ẽ" again - instead of "ẽ"), depending on the server locale setting. To ensure correct behavior, we must convert into unicode first, using s3_unicode:
-
-{{{
-   s_lowercase = s3_unicode(s).lower().encode("utf-8")
-}}}
+8) All code is utf-8 encoded, so that all string constants are automatically utf-8 encoded str. We do not use u"..." for string constants.
 === Tools ===