Changes between Version 89 and Version 90 of DeveloperGuidelines/Git

Timestamp:

01/03/14 03:48:08 (11 years ago)

Author:

Pat Tressel

Comment:

--

DeveloperGuidelines/Git

@@ -270 +270 @@
 === Getting your changes accepted into the trunk repository ===
 
-Before submitting code to be included in the trunk repository, two things should be done:
+Before submitting code to be included in the trunk repository, several things should be done:
 1. Rebase from trunk and deal with any merge conflicts.
 1. Squash all commits in your change into one commit. This removes any false steps and re-working, and packages the related work together.
+1. Test after rebasing.
+1. Push your changes to your own fork of Eden on GitHub.
+1. Ask for a code review if appropriate.
+
+Once you are ready to submit your work, make a pull request:  Click Pull Requests on the right side of the GitHub page for your repo then the New Pull Request button.  Note if you already have a pull request open, then changes you push to the branch that is the source of the pull request will be included in it automatically -- you do not need to close the pull request and make a new one.
 
 === Working with multiple branches ===