Changes between Version 90 and Version 91 of DeveloperGuidelines/Git
- Timestamp:
- 01/03/14 03:50:59 (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
DeveloperGuidelines/Git
v90 v91 268 268 }}} 269 269 270 === Code review on !GitHub === 271 270 272 === Getting your changes accepted into the trunk repository === 271 273 … … 274 276 1. Squash all commits in your change into one commit. This removes any false steps and re-working, and packages the related work together. 275 277 1. Test after rebasing. 276 1. Push your changes to your own fork of Eden on GitHub.278 1. Push your changes to your own fork of Eden on !GitHub. 277 279 1. Ask for a code review if appropriate. 278 280 279 Once you are ready to submit your work, make a pull request: Click Pull Requests on the right side of the GitHub page for your repo then the New Pull Request button. Note if you already have a pull request open, then changes you push to the branch that is the source of the pull request will be included in it automatically -- you do not need to close the pull request and make a new one.281 Once you are ready to submit your work, make a pull request: Click Pull Requests on the right side of the !GitHub page for your repo then the New Pull Request button. Note if you already have a pull request open, then changes you push to the branch that is the source of the pull request will be included in it automatically -- you do not need to close the pull request and make a new one. 280 282 281 283 === Working with multiple branches ===