Changes between Version 95 and Version 96 of DeveloperGuidelines/Git

Timestamp:

01/12/14 10:37:58 (11 years ago)

Author:

Pat Tressel

Comment:

--

DeveloperGuidelines/Git

@@ -270 +270 @@
 === Code review on !GitHub ===
 
+''Under construction''
+
 Code reviews help assure that code is correct before it gets accepted into trunk by having other people besides the author examine it, install it, test it, and comment on it.  !GitHub provides some very convenient features for conducting code reviews.
 
 * The code author can push their changes to !GitHub, which makes it easy for the reviewer to pull their changes into their own repository.
-* !GitHub allows commenting on specific lines in a file or in a diff between revisions.  This makes it easy to show exactly what code is being commented on.
+* !GitHub allows commenting on specific lines in a file or in a diff between revisions.  This makes it easy to show exactly what code is being commented on.  It is not necessary to squash commits or make a pull request at this point, but the reviewer will need a way to see your changes as a whole.
+
+To prepare for a code review:
+
+* Optionally squash your commits.
+* Push your changes to !GitHub.
+* If your change contains more than one commit (and you are not doing a pull request yet) 
 === Getting your changes accepted into the trunk repository ===